From 98dce2d47cb8d8fa97aa5c9f744633f3be774576 Mon Sep 17 00:00:00 2001 From: maximo tejeda Date: Mon, 2 Dec 2024 20:32:29 -0400 Subject: [PATCH] fix err handling --- Dockerfile | 2 -- internal/adapters/crawler/apap.go | 4 ++-- internal/adapters/crawler/bcd.go | 2 +- internal/adapters/crawler/bdr.go | 4 ++-- internal/adapters/crawler/bhd.go | 2 +- internal/adapters/crawler/bnc.go | 2 +- internal/adapters/crawler/bpd.go | 8 ++++---- internal/adapters/crawler/crawler.go | 2 +- internal/adapters/crawler/inf.go | 2 +- internal/adapters/crawler/scotia.go | 2 +- internal/adapters/crawler/vimenca.go | 2 +- 11 files changed, 15 insertions(+), 17 deletions(-) diff --git a/Dockerfile b/Dockerfile index 446e176..97f209a 100644 --- a/Dockerfile +++ b/Dockerfile @@ -4,8 +4,6 @@ ARG version=not-set ARG SHORTSHA=not-set WORKDIR /app COPY . . -ENV GOPRIVATE=git.maximotejeda.com/maximo,github.com/maximotejeda -ENV GOPROXY=direct # https://stackoverflow.com/questions/70369368/check-architecture-in-dockerfile-to-get-amd-arm RUN go build -o bin/crawler \ -ldflags "-X main.Shortsha=${SHORTSHA} \ diff --git a/internal/adapters/crawler/apap.go b/internal/adapters/crawler/apap.go index b0f756d..68cf30a 100644 --- a/internal/adapters/crawler/apap.go +++ b/internal/adapters/crawler/apap.go @@ -30,8 +30,8 @@ func (a Apap) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger return nil, err } button := page.Locator("#exchangesRates") - button.WaitFor() - button.Click() + _ = button.WaitFor() + _ = button.Click() compraLocator := page.Locator("#currency-buy-USD") ventaLocator := page.Locator("#currency-sell-USD") diff --git a/internal/adapters/crawler/bcd.go b/internal/adapters/crawler/bcd.go index 158e59a..5af83bc 100644 --- a/internal/adapters/crawler/bcd.go +++ b/internal/adapters/crawler/bcd.go @@ -31,7 +31,7 @@ func (b bcd) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger) } compraLocator := page.Locator("span#actualPurchaseValue") - compraLocator.WaitFor(playwright.LocatorWaitForOptions{ + _ = compraLocator.WaitFor(playwright.LocatorWaitForOptions{ Timeout: &tout, State: playwright.WaitForSelectorStateVisible, }) diff --git a/internal/adapters/crawler/bdr.go b/internal/adapters/crawler/bdr.go index 30b7385..9e729ae 100644 --- a/internal/adapters/crawler/bdr.go +++ b/internal/adapters/crawler/bdr.go @@ -35,9 +35,9 @@ func (bd brd) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger return nil, err } - page.Locator("section#divisas").WaitFor() + _ = page.Locator("section#divisas").WaitFor() compraLocator := page.Locator("span#compraUS") - compraLocator.WaitFor() + _ = compraLocator.WaitFor() ventaLocator := page.Locator("span#ventaUS") compraSTR, err := compraLocator.TextContent() if err != nil { diff --git a/internal/adapters/crawler/bhd.go b/internal/adapters/crawler/bhd.go index 7aee13d..6a35f33 100644 --- a/internal/adapters/crawler/bhd.go +++ b/internal/adapters/crawler/bhd.go @@ -46,7 +46,7 @@ func (bh bhd) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger } fieldGroupLocator := page.Locator("div.field_group") - fieldGroupLocator.WaitFor() + _ = fieldGroupLocator.WaitFor() fieldGroup, err := fieldGroupLocator.All() //log.Info("divs", "number", len(fieldGroup)) if err != nil { diff --git a/internal/adapters/crawler/bnc.go b/internal/adapters/crawler/bnc.go index 3ac274c..29dc731 100644 --- a/internal/adapters/crawler/bnc.go +++ b/internal/adapters/crawler/bnc.go @@ -31,7 +31,7 @@ func (bn bnc) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger } currencyDiv := page.Locator(".calculator__content") - currencyDiv.WaitFor() + _ = currencyDiv.WaitFor() buyInput := page.Locator("div.calculator__buy-input:nth-child(2) > input:nth-child(2)") diff --git a/internal/adapters/crawler/bpd.go b/internal/adapters/crawler/bpd.go index 309ad7d..4523a00 100644 --- a/internal/adapters/crawler/bpd.go +++ b/internal/adapters/crawler/bpd.go @@ -35,15 +35,15 @@ func (bp bpd) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger //log.Info("Page loaded", "time", time.Since(start).Seconds()) // menu := page.Locator(".footer_est_menu_bpd > li:nth-child(3)") container := page.Locator("div.tasa.tasa_dolar") - container.WaitFor() + _ = container.WaitFor() compraInput := page.Locator("input#compra_peso_dolar") - compraInput.WaitFor(playwright.LocatorWaitForOptions{ + _ = compraInput.WaitFor(playwright.LocatorWaitForOptions{ Timeout: &tout, State: playwright.WaitForSelectorStateVisible, }) ventaInput := page.Locator("input#venta_peso_dolar") - ventaInput.WaitFor() + _ = ventaInput.WaitFor() compraSTR, err := compraInput.InputValue() if err != nil { log.Error("compra value", "err", err) @@ -81,5 +81,5 @@ func (bp bpd) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger func HoverTasas(page playwright.Page) { tasasMenu := page.Locator(".footer_est_menu_bpd > li:nth-child(3)") - tasasMenu.Hover() + _ = tasasMenu.Hover() } diff --git a/internal/adapters/crawler/crawler.go b/internal/adapters/crawler/crawler.go index b716e76..f10969d 100644 --- a/internal/adapters/crawler/crawler.go +++ b/internal/adapters/crawler/crawler.go @@ -28,7 +28,7 @@ func Selector(who string, client ports.DollarPort) (ports.APIPorts, error) { case "vimenca": parser = NewVimenca() default: - return nil, fmt.Errorf("not recognize who: " + who) + return nil, fmt.Errorf("not recognize who: %s", who) } return parser, nil } diff --git a/internal/adapters/crawler/inf.go b/internal/adapters/crawler/inf.go index d0d89b8..cf923eb 100644 --- a/internal/adapters/crawler/inf.go +++ b/internal/adapters/crawler/inf.go @@ -32,7 +32,7 @@ func (in inf) Scrape(ctx context.Context, page playwright.Page, log *slog.Logger } entriesLocator := page.Locator("table#Dolar > tbody > tr") - entriesLocator.WaitFor(playwright.LocatorWaitForOptions{ + _ = entriesLocator.WaitFor(playwright.LocatorWaitForOptions{ Timeout: &tout, State: playwright.WaitForSelectorStateVisible, }) diff --git a/internal/adapters/crawler/scotia.go b/internal/adapters/crawler/scotia.go index c450dd3..925a958 100644 --- a/internal/adapters/crawler/scotia.go +++ b/internal/adapters/crawler/scotia.go @@ -32,7 +32,7 @@ func (sct scotia) Scrape(ctx context.Context, page playwright.Page, log *slog.Lo } currencyTable := page.Locator(".bns--table") - currencyTable.WaitFor() + _ = currencyTable.WaitFor() firstRow := page.Locator(".bns--table > tbody:nth-child(1) > tr:nth-child(2)") secondRow := page.Locator(".bns--table > tbody:nth-child(1) > tr:nth-child(3)") diff --git a/internal/adapters/crawler/vimenca.go b/internal/adapters/crawler/vimenca.go index bf9b801..e1444b6 100644 --- a/internal/adapters/crawler/vimenca.go +++ b/internal/adapters/crawler/vimenca.go @@ -30,7 +30,7 @@ func (v vimenca) Scrape(ctx context.Context, page playwright.Page, log *slog.Log } currencyTable := page.Locator(".bns--table") - currencyTable.WaitFor() + _ = currencyTable.WaitFor() infoContainer := page.Locator(".layout-uikit > div:nth-child(1)")